Discussion:
RFR: 8202583: Remove experimental ClassForNamePlugin
(too old to reply)
Claes Redestad
2018-05-07 13:23:47 UTC
Permalink
Hi,

the --class-for-name jlink plugin was added as an experiment to test and
evolve the jlink plugin infrastructure. The actual effect of enabling
this plugin on standard images is very limited (only a handful of
Class.forName:s are replaced) and turns out it can be a breaking change
since replacing a Class.forName isn't semantically identical with an ldc
of the class (the latter won't trigger class initialization).

Thus, since this plugin isn't very profitable and potentially dangerous,
I suggest removing it: http://cr.openjdk.java.net/~redestad/8202583/open.00/

An open question is whether a CSR is required to remove this.

Thanks!

/Claes
Jim Laskey
2018-05-07 13:29:53 UTC
Permalink
+1
Hi,
the --class-for-name jlink plugin was added as an experiment to test and evolve the jlink plugin infrastructure. The actual effect of enabling this plugin on standard images is very limited (only a handful of Class.forName:s are replaced) and turns out it can be a breaking change since replacing a Class.forName isn't semantically identical with an ldc of the class (the latter won't trigger class initialization).
Thus, since this plugin isn't very profitable and potentially dangerous, I suggest removing it: http://cr.openjdk.java.net/~redestad/8202583/open.00/
An open question is whether a CSR is required to remove this.
Thanks!
/Claes
Alan Bateman
2018-05-07 14:46:03 UTC
Permalink
Post by Claes Redestad
Hi,
the --class-for-name jlink plugin was added as an experiment to test
and evolve the jlink plugin infrastructure. The actual effect of
enabling this plugin on standard images is very limited (only a
handful of Class.forName:s are replaced) and turns out it can be a
breaking change since replacing a Class.forName isn't semantically
identical with an ldc of the class (the latter won't trigger class
initialization).
Thus, since this plugin isn't very profitable and potentially
http://cr.openjdk.java.net/~redestad/8202583/open.00/
The changes looks fine.
Post by Claes Redestad
An open question is whether a CSR is required to remove this.
It's an experimental/undocumented/unsupported plugin so just removing it
should be fine (the original CSR equivalent that added jlink didn't not
mention this plugin).

-Alan
mandy chung
2018-05-07 16:45:37 UTC
Permalink
Post by Claes Redestad
Hi,
the --class-for-name jlink plugin was added as an experiment to test
and evolve the jlink plugin infrastructure. The actual effect of
enabling this plugin on standard images is very limited (only a
handful of Class.forName:s are replaced) and turns out it can be a
breaking change since replacing a Class.forName isn't semantically
identical with an ldc of the class (the latter won't trigger class
initialization).
Thus, since this plugin isn't very profitable and potentially
http://cr.openjdk.java.net/~redestad/8202583/open.00/
+1
Post by Claes Redestad
An open question is whether a CSR is required to remove this.
This is an experimental and unsupported plugin.  I agree with Alan that
no CSR is needed for this change.

Mandy

Loading...