Discussion:
Review Request JDK-8200121: Remove unused qualified exports in java.base
(too old to reply)
mandy chung
2018-06-15 16:34:50 UTC
Permalink
A simple cleanup to remove unused qualified exports in java.base.

The webrev also includes a fix for JDK-8205116 (jdeps --system
$java.home fails) that I uncovered through this process where I ran
`jdeps --check java.base --system $java.home` on the JDK binaries on
several platforms.

Webrev at:
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/

Mandy
Lance Andersen
2018-06-15 16:53:12 UTC
Permalink
Hi Mandy,

The changes look good

Best
Lance
Post by mandy chung
JDK-8205116
<Loading Image...>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
***@oracle.com <mailto:***@oracle.com>
Alan Bateman
2018-06-15 17:47:30 UTC
Permalink
Post by mandy chung
A simple cleanup to remove unused qualified exports in java.base.
The webrev also includes a fix for JDK-8205116 (jdeps --system
$java.home fails) that I uncovered through this process where I ran
`jdeps --check java.base --system $java.home` on the JDK binaries on
several platforms.
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/
Looks good.

-Alan
mandy chung
2018-06-15 19:14:03 UTC
Permalink
Alan, Lance,

I added a test case for JDK-8205116 in
test/langtools/tools/jdeps/Options.java.

Updated webrev for JDK-8205116 only:
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/

Mandy
Post by Alan Bateman
Post by mandy chung
A simple cleanup to remove unused qualified exports in java.base.
The webrev also includes a fix for JDK-8205116 (jdeps --system
$java.home fails) that I uncovered through this process where I ran
`jdeps --check java.base --system $java.home` on the JDK binaries on
several platforms.
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/
Looks good.
-Alan
Lance Andersen
2018-06-15 19:37:45 UTC
Permalink
Hi Mandy

The test that was added seems fine.

Best
Lance
Post by mandy chung
Alan, Lance,
I added a test case for JDK-8205116 in test/langtools/tools/jdeps/Options.java.
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/
Mandy
Post by Alan Bateman
Post by mandy chung
A simple cleanup to remove unused qualified exports in java.base.
The webrev also includes a fix for JDK-8205116 (jdeps --system $java.home fails) that I uncovered through this process where I ran `jdeps --check java.base --system $java.home` on the JDK binaries on several platforms.
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/
Looks good.
-Alan
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
***@oracle.com <mailto:***@oracle.com>
Alan Bateman
2018-06-15 19:45:06 UTC
Permalink
Post by mandy chung
Alan, Lance,
I added a test case for JDK-8205116 in
test/langtools/tools/jdeps/Options.java.
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/
This looks okay (although "valid $java.home" should be "valid path").

-Alan
mandy chung
2018-06-15 20:04:37 UTC
Permalink
Post by Alan Bateman
Post by mandy chung
Alan, Lance,
I added a test case for JDK-8205116 in
test/langtools/tools/jdeps/Options.java.
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/
This looks okay (although "valid $java.home" should be "valid path").
Fixed.

Mandy

Loading...