RFR - JImageListTest test fix

[Michal Vala]

Hi,

sending patch fixing JImageListTest failing tests. It was in ProblemList and
this fix greens the test case, so the patch also removes it from the list.
It will probably need new bug id and I will need a sponsor for this.

Fix itself is simple. There was incorrect assert for list of images contains
java.base image as it was testing index of "java.base" > 0 and it's usually at
first place, thus index 0. I've changed it to List#contains.

Thanks!

[Alan Bateman]

Post by Michal Vala
Hi,
sending patch fixing JImageListTest failing tests. It was in
ProblemList and this fix greens the test case, so the patch also
removes it from the list.
It will probably need new bug id and I will need a sponsor for this.
Fix itself is simple. There was incorrect assert for list of images
contains java.base image as it was testing index of "java.base" > 0
and it's usually at first place, thus index 0. I've changed it to
List#contains.

This looks okay to me.

-Alan

[Alan Bateman]

Post by Michal Vala
Hi,
sending patch fixing JImageListTest failing tests. It was in
ProblemList and this fix greens the test case, so the patch also
removes it from the list.

These tests are failing on Windows now. Nothing to do with your changes,
it seems the original tests added via JDK-8167240 weren't run enough to
shake out issues with the tests. So we need to re-add them to the
exclude list, Sundar has already reviewed.

-Alan

diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt
+++ b/test/jdk/ProblemList.txt
@@ -464,6 +464,9 @@

 tools/launcher/FXLauncherTest.java 8068049 linux-all,macosx-all

+tools/jimage/JImageExtractTest.java 8198405 windows-all
+tools/jimage/JImageListTest.java 8198405 windows-all
+
 ############################################################################

[Michal Vala]

Post by Michal Vala
Hi,
sending patch fixing JImageListTest failing tests. It was in ProblemList and
this fix greens the test case, so the patch also removes it from the list.

These tests are failing on Windows now. Nothing to do with your changes, it
seems the original tests added via JDK-8167240 weren't run enough to shake out
issues with the tests. So we need to re-add them to the exclude list, Sundar has
already reviewed.

ok, I can take a look at them

-Alan
diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt
+++ b/test/jdk/ProblemList.txt
@@ -464,6 +464,9 @@
 tools/launcher/FXLauncherTest.java 8068049 linux-all,macosx-all
+tools/jimage/JImageExtractTest.java 8198405 windows-all
+tools/jimage/JImageListTest.java 8198405 windows-all
+
 ############################################################################