Discussion:
ModuleDescriptor#toString(Set<>, String) may produce unexpected results.
Andrej Golovnin
2017-12-12 07:20:56 UTC
Permalink
Hi all,

the ModuleDescriptor#toString(Set<>, String) method uses
String#toLowerCase() in the line 2607 without specifying a locale. And
this may lead to unexpected results when you start the JVM for example
with the Turkish locale. This can be fixed by using
String#toLowerCase(Locale) with Locale.ROOT as the argument.

The suggested change is attached as diff.

Best regards,
Andrej Golovnin
Alan Bateman
2017-12-12 11:59:15 UTC
Permalink
Post by Andrej Golovnin
Hi all,
the ModuleDescriptor#toString(Set<>, String) method uses
String#toLowerCase() in the line 2607 without specifying a locale. And
this may lead to unexpected results when you start the JVM for example
with the Turkish locale. This can be fixed by using
String#toLowerCase(Locale) with Locale.ROOT as the argument.
Thanks, this should be using toLowerCase(Locale). I'll create a bug for
this.

-Alan
Andrej Golovnin
2017-12-12 13:45:09 UTC
Permalink
Post by Alan Bateman
Thanks, this should be using toLowerCase(Locale). I'll create a bug for
this.
Thanks, Alan!

Best regards,
Andrej Golovnin

Loading...