Discussion:
RFR: 8201794: [Graal] add dummy HotSpotGraalManagement class
(too old to reply)
Doug Simon
2018-04-18 10:35:22 UTC
Permalink
Right after pushing the change for JDK-8187490, I noticed that the mach5 build had 2 CTW test failures due to jdk.internal.vm.compiler.management now being an empty module. This will be fixed in the next Graal update but the failing tests should be fixed in the meantime.

http://cr.openjdk.java.net/~dnsimon/8201794/
https://bugs.openjdk.java.net/browse/JDK-8201794

I'm running mach5 now to ensure the regressions are fixed and no other regressions occur.

-Doug
Doug Simon
2018-04-18 11:00:52 UTC
Permalink
I've updated the webrev with a fix for another regression caused by JDK-8187490:

--- old/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
+++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
@@ -46,6 +46,7 @@
List.of("java.compiler",
"java.jnlp",
"jdk.internal.vm.compiler",
+ "jdk.internal.vm.compiler.management",
"jdk.deploy",
"jdk.javaws",
"jdk.plugin",

-Doug
Post by Doug Simon
Right after pushing the change for JDK-8187490, I noticed that the mach5 build had 2 CTW test failures due to jdk.internal.vm.compiler.management now being an empty module. This will be fixed in the next Graal update but the failing tests should be fixed in the meantime.
http://cr.openjdk.java.net/~dnsimon/8201794/
https://bugs.openjdk.java.net/browse/JDK-8201794
I'm running mach5 now to ensure the regressions are fixed and no other regressions occur.
-Doug
mandy chung
2018-04-18 11:23:23 UTC
Permalink
Looks okay.  Have you run all jdk_core tests in addition to other
hotspot tests.

Mandy
Post by Doug Simon
--- old/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
+++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
@@ -46,6 +46,7 @@
List.of("java.compiler",
"java.jnlp",
"jdk.internal.vm.compiler",
+ "jdk.internal.vm.compiler.management",
"jdk.deploy",
"jdk.javaws",
"jdk.plugin",
-Doug
Post by Doug Simon
Right after pushing the change for JDK-8187490, I noticed that the mach5 build had 2 CTW test failures due to jdk.internal.vm.compiler.management now being an empty module. This will be fixed in the next Graal update but the failing tests should be fixed in the meantime.
http://cr.openjdk.java.net/~dnsimon/8201794/
https://bugs.openjdk.java.net/browse/JDK-8201794
I'm running mach5 now to ensure the regressions are fixed and no other regressions occur.
-Doug
Doug Simon
2018-04-18 11:28:21 UTC
Permalink
Looks okay. Have you run all jdk_core tests in addition to other hotspot tests.
I ran all open/test/jdk/jdk tests - is that what you mean?

-Doug
Post by Doug Simon
--- old/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
+++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
@@ -46,6 +46,7 @@
List.of("java.compiler",
"java.jnlp",
"jdk.internal.vm.compiler",
+ "jdk.internal.vm.compiler.management",
"jdk.deploy",
"jdk.javaws",
"jdk.plugin",
-Doug
Post by Doug Simon
Right after pushing the change for JDK-8187490, I noticed that the mach5 build had 2 CTW test failures due to jdk.internal.vm.compiler.management now being an empty module. This will be fixed in the next Graal update but the failing tests should be fixed in the meantime.
http://cr.openjdk.java.net/~dnsimon/8201794/
https://bugs.openjdk.java.net/browse/JDK-8201794
I'm running mach5 now to ensure the regressions are fixed and no other regressions occur.
-Doug
Alan Bateman
2018-04-18 11:28:29 UTC
Permalink
Post by Doug Simon
--- old/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
+++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java 2018-04-18 12:57:32.000000000 +0200
@@ -46,6 +46,7 @@
List.of("java.compiler",
"java.jnlp",
"jdk.internal.vm.compiler",
+ "jdk.internal.vm.compiler.management",
"jdk.deploy",
"jdk.javaws",
"jdk.plugin",
This looks fine, this seems to be the only jdk_core test failing after
JDK-8187490.

-Alan
Loading...