Discussion:
RFR(XS): 8205025: [AOT] make jdk.aot module upgradeable
(too old to reply)
Doug Simon
2018-06-14 08:09:38 UTC
Permalink
In the context of JDK-8202762, we to need to make the jdk.aot module upgradeable. Otherwise, it is impossible to run or test the version of jdk.aot under development in a Graal repo:

java --module-path=../sdk/mxbuild/modules/org.graalvm.graal_sdk.jar:../truffle/mxbuild/modules/com.oracle.truffle.truffle_api.jar:mxbuild/modules/jdk.internal.vm.compiler.jar --upgrade-module-path=mxbuild/modules/jdk.internal.vm.compiler.jar:mxbuild/modules/jdk.internal.vm.compiler.management.jar:mxbuild/modules/jdk.aot.jar -m jdk.aot/jdk.tools.jaotc.Main
Error occurred during initialization of boot layer
java.lang.module.FindException: Hash of jdk.aot (55cfefcfb0ca2a8b12403c47848d2bbd54416149cfe75f5051ad77628a2764b4) differs to expected hash (e6882d3461a21ea46c52da87ef52b5850a7b1f5ae0cfd650b7f784c970aaa0ee) recorded in java.base

https://bugs.openjdk.java.net/browse/JDK-8205025
http://cr.openjdk.java.net/~dnsimon/8205025/

-Doug
Alan Bateman
2018-06-14 10:03:42 UTC
Permalink
Post by Doug Simon
java --module-path=../sdk/mxbuild/modules/org.graalvm.graal_sdk.jar:../truffle/mxbuild/modules/com.oracle.truffle.truffle_api.jar:mxbuild/modules/jdk.internal.vm.compiler.jar --upgrade-module-path=mxbuild/modules/jdk.internal.vm.compiler.jar:mxbuild/modules/jdk.internal.vm.compiler.management.jar:mxbuild/modules/jdk.aot.jar -m jdk.aot/jdk.tools.jaotc.Main
Error occurred during initialization of boot layer
java.lang.module.FindException: Hash of jdk.aot (55cfefcfb0ca2a8b12403c47848d2bbd54416149cfe75f5051ad77628a2764b4) differs to expected hash (e6882d3461a21ea46c52da87ef52b5850a7b1f5ae0cfd650b7f784c970aaa0ee) recorded in java.base
https://bugs.openjdk.java.net/browse/JDK-8205025
http://cr.openjdk.java.net/~dnsimon/8205025/
This looks okay except that there has been an attempt to keep the list
of modules in alphabetic order in these make files.

Do all tests pass with this change? There is at least one test in
test/jdk/jdk/modules/etc that is sensitive to the list of upgradeable
modules.

-Alan.
Doug Simon
2018-06-14 16:35:00 UTC
Permalink
Post by Doug Simon
java --module-path=../sdk/mxbuild/modules/org.graalvm.graal_sdk.jar:../truffle/mxbuild/modules/com.oracle.truffle.truffle_api.jar:mxbuild/modules/jdk.internal.vm.compiler.jar --upgrade-module-path=mxbuild/modules/jdk.internal.vm.compiler.jar:mxbuild/modules/jdk.internal.vm.compiler.management.jar:mxbuild/modules/jdk.aot.jar -m jdk.aot/jdk.tools.jaotc.Main
Error occurred during initialization of boot layer
java.lang.module.FindException: Hash of jdk.aot (55cfefcfb0ca2a8b12403c47848d2bbd54416149cfe75f5051ad77628a2764b4) differs to expected hash (e6882d3461a21ea46c52da87ef52b5850a7b1f5ae0cfd650b7f784c970aaa0ee) recorded in java.base
https://bugs.openjdk.java.net/browse/JDK-8205025
http://cr.openjdk.java.net/~dnsimon/8205025/
This looks okay except that there has been an attempt to keep the list of modules in alphabetic order in these make files.
Do all tests pass with this change? There is at least one test in test/jdk/jdk/modules/etc that is sensitive to the list of upgradeable modules.
I changed the test (thanks Mandy for pointing out exactly which one), fixed the alphabetic ordering of the list and am running tests now.

-Doug
Lance Andersen
2018-06-14 16:56:57 UTC
Permalink
Test change and the update to the name ordering looks good
Post by Doug Simon
Post by Doug Simon
java --module-path=../sdk/mxbuild/modules/org.graalvm.graal_sdk.jar:../truffle/mxbuild/modules/com.oracle.truffle.truffle_api.jar:mxbuild/modules/jdk.internal.vm.compiler.jar --upgrade-module-path=mxbuild/modules/jdk.internal.vm.compiler.jar:mxbuild/modules/jdk.internal.vm.compiler.management.jar:mxbuild/modules/jdk.aot.jar -m jdk.aot/jdk.tools.jaotc.Main
Error occurred during initialization of boot layer
java.lang.module.FindException: Hash of jdk.aot (55cfefcfb0ca2a8b12403c47848d2bbd54416149cfe75f5051ad77628a2764b4) differs to expected hash (e6882d3461a21ea46c52da87ef52b5850a7b1f5ae0cfd650b7f784c970aaa0ee) recorded in java.base
https://bugs.openjdk.java.net/browse/JDK-8205025
http://cr.openjdk.java.net/~dnsimon/8205025/
This looks okay except that there has been an attempt to keep the list of modules in alphabetic order in these make files.
Do all tests pass with this change? There is at least one test in test/jdk/jdk/modules/etc that is sensitive to the list of upgradeable modules.
I changed the test (thanks Mandy for pointing out exactly which one), fixed the alphabetic ordering of the list and am running tests now.
-Doug
<Loading Image...>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
***@oracle.com <mailto:***@oracle.com>
Alan Bateman
2018-06-14 17:01:37 UTC
Permalink
Post by Doug Simon
This looks okay except that there has been an attempt to keep the list of modules in alphabetic order in these make files.
Do all tests pass with this change? There is at least one test in test/jdk/jdk/modules/etc that is sensitive to the list of upgradeable modules.
I changed the test (thanks Mandy for pointing out exactly which one), fixed the alphabetic ordering of the list and am running tests now.
The updated webrev looks good to me.

-Alan
Vladimir Kozlov
2018-06-14 17:26:02 UTC
Permalink
Good.

Thanks,
Vladimir
Post by Doug Simon
Post by Doug Simon
java --module-path=../sdk/mxbuild/modules/org.graalvm.graal_sdk.jar:../truffle/mxbuild/modules/com.oracle.truffle.truffle_api.jar:mxbuild/modules/jdk.internal.vm.compiler.jar --upgrade-module-path=mxbuild/modules/jdk.internal.vm.compiler.jar:mxbuild/modules/jdk.internal.vm.compiler.management.jar:mxbuild/modules/jdk.aot.jar -m jdk.aot/jdk.tools.jaotc.Main
Error occurred during initialization of boot layer
java.lang.module.FindException: Hash of jdk.aot (55cfefcfb0ca2a8b12403c47848d2bbd54416149cfe75f5051ad77628a2764b4) differs to expected hash (e6882d3461a21ea46c52da87ef52b5850a7b1f5ae0cfd650b7f784c970aaa0ee) recorded in java.base
https://bugs.openjdk.java.net/browse/JDK-8205025
http://cr.openjdk.java.net/~dnsimon/8205025/
This looks okay except that there has been an attempt to keep the list of modules in alphabetic order in these make files.
Do all tests pass with this change? There is at least one test in test/jdk/jdk/modules/etc that is sensitive to the list of upgradeable modules.
I changed the test (thanks Mandy for pointing out exactly which one), fixed the alphabetic ordering of the list and am running tests now.
-Doug
mandy chung
2018-06-14 17:28:35 UTC
Permalink
Post by Doug Simon
I changed the test (thanks Mandy for pointing out exactly which one),
fixed the alphabetic ordering of the list and am running tests now.
I reviewed http://cr.openjdk.java.net/~dnsimon/8205025/. Looks good.

Mandy

mandy chung
2018-06-14 14:17:48 UTC
Permalink
test/jdk/jdk/modules/etc/UpgradeableModules.java needs to be updated as
it keeps the list of upgradeable modules as well to verify the hashes in
java.base.

Mandy
Post by Doug Simon
java --module-path=../sdk/mxbuild/modules/org.graalvm.graal_sdk.jar:../truffle/mxbuild/modules/com.oracle.truffle.truffle_api.jar:mxbuild/modules/jdk.internal.vm.compiler.jar --upgrade-module-path=mxbuild/modules/jdk.internal.vm.compiler.jar:mxbuild/modules/jdk.internal.vm.compiler.management.jar:mxbuild/modules/jdk.aot.jar -m jdk.aot/jdk.tools.jaotc.Main
Error occurred during initialization of boot layer
java.lang.module.FindException: Hash of jdk.aot (55cfefcfb0ca2a8b12403c47848d2bbd54416149cfe75f5051ad77628a2764b4) differs to expected hash (e6882d3461a21ea46c52da87ef52b5850a7b1f5ae0cfd650b7f784c970aaa0ee) recorded in java.base
https://bugs.openjdk.java.net/browse/JDK-8205025
http://cr.openjdk.java.net/~dnsimon/8205025/
-Doug
Loading...