Discussion:
Review Request 8205112: Remove non-existent modules from test/jdk/jdk/modules/etc/UpgradeableModules.java
(too old to reply)
mandy chung
2018-06-15 16:12:48 UTC
Permalink
This patch cleans up the list of upgradeable modules kept in
test/jdk/jdk/modules/etc/UpgradeableModules.java test verification and
take out the modules that have been removed.

thanks
Mandy

--- a/test/jdk/jdk/modules/etc/UpgradeableModules.java
+++ b/test/jdk/jdk/modules/etc/UpgradeableModules.java
@@ -44,14 +44,8 @@
public class UpgradeableModules {
private static final List<String> UPGRADEABLE_MODULES =
List.of("java.compiler",
- "java.jnlp",
"jdk.internal.vm.compiler",
- "jdk.internal.vm.compiler.management",
- "jdk.deploy",
- "jdk.javaws",
- "jdk.plugin",
- "jdk.plugin.dom"
- );
+ "jdk.internal.vm.compiler.management");

public static void main(String... args) {
Set<String> hashedModules = hashedModules();
Lance Andersen
2018-06-15 16:16:53 UTC
Permalink
+1
This patch cleans up the list of upgradeable modules kept in test/jdk/jdk/modules/etc/UpgradeableModules.java test verification and take out the modules that have been removed.
thanks
Mandy
--- a/test/jdk/jdk/modules/etc/UpgradeableModules.java
+++ b/test/jdk/jdk/modules/etc/UpgradeableModules.java
@@ -44,14 +44,8 @@
public class UpgradeableModules {
private static final List<String> UPGRADEABLE_MODULES =
List.of("java.compiler",
- "java.jnlp",
"jdk.internal.vm.compiler",
- "jdk.internal.vm.compiler.management",
- "jdk.deploy",
- "jdk.javaws",
- "jdk.plugin",
- "jdk.plugin.dom"
- );
+ "jdk.internal.vm.compiler.management");
public static void main(String... args) {
Set<String> hashedModules = hashedModules();
<Loading Image...>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
***@oracle.com <mailto:***@oracle.com>
Kevin Rushforth
2018-06-15 16:57:48 UTC
Permalink
Looks good to me.

-- Kevin
Post by mandy chung
This patch cleans up the list of upgradeable modules kept in
test/jdk/jdk/modules/etc/UpgradeableModules.java test verification and
take out the modules that have been removed.
thanks
Mandy
--- a/test/jdk/jdk/modules/etc/UpgradeableModules.java
+++ b/test/jdk/jdk/modules/etc/UpgradeableModules.java
@@ -44,14 +44,8 @@
 public class UpgradeableModules {
     private static final List<String> UPGRADEABLE_MODULES =
         List.of("java.compiler",
-                "java.jnlp",
                 "jdk.internal.vm.compiler",
-                "jdk.internal.vm.compiler.management",
-                "jdk.deploy",
-                "jdk.javaws",
-                "jdk.plugin",
-                "jdk.plugin.dom"
-                );
+                "jdk.internal.vm.compiler.management");
     public static void main(String... args) {
         Set<String> hashedModules = hashed
Alan Bateman
2018-06-15 17:48:01 UTC
Permalink
Post by mandy chung
This patch cleans up the list of upgradeable modules kept in
test/jdk/jdk/modules/etc/UpgradeableModules.java test verification and
take out the modules that have been removed.
Looks okay to me.

-Alan

Loading...