Discussion:
RFR: 8205926: Support invokeSpecialIFC in GenerateJLIClassesPlugin
(too old to reply)
Claes Redestad
2018-06-27 13:40:56 UTC
Permalink
Hi,

JDK-8200167 <https://bugs.openjdk.java.net/browse/JDK-8200167>
introduced a new DMH kind, invokeSpecialIFC, which slightly perturbed
what forms we see on startup, which is linked to some minor startup
regressions in 11+19

Add support for this new kind in the plugin, and refresh what invokers
and forms we generate by default. Hard-coding defaults into the plugin
is crude and the intent is to
remove all that in favor of extended build-time profiling support (see
HelloClasslist), but this will require more time, and I'd like to get
this regression fix
into 11 to avoid a few small startup regressions that crept into the
last couple of promoted builds.

Webrev: http://cr.openjdk.java.net/~redestad/8205926/jdk.00/

Thanks!

/Claes
Paul Sandoz
2018-06-27 17:25:54 UTC
Permalink
+1

Paul.
Hi,
JDK-8200167 <https://bugs.openjdk.java.net/browse/JDK-8200167> introduced a new DMH kind, invokeSpecialIFC, which slightly perturbed what forms we see on startup, which is linked to some minor startup regressions in 11+19
Add support for this new kind in the plugin, and refresh what invokers and forms we generate by default. Hard-coding defaults into the plugin is crude and the intent is to
remove all that in favor of extended build-time profiling support (see HelloClasslist), but this will require more time, and I'd like to get this regression fix
into 11 to avoid a few small startup regressions that crept into the last couple of promoted builds.
Webrev: http://cr.openjdk.java.net/~redestad/8205926/jdk.00/
Thanks!
/Claes
mandy chung
2018-06-27 18:21:42 UTC
Permalink
Post by Claes Redestad
Hi,
JDK-8200167 <https://bugs.openjdk.java.net/browse/JDK-8200167>
introduced a new DMH kind, invokeSpecialIFC, which slightly perturbed
what forms we see on startup, which is linked to some minor startup
regressions in 11+19
Add support for this new kind in the plugin, and refresh what invokers
and forms we generate by default. Hard-coding defaults into the plugin
is crude and the intent is to
remove all that in favor of extended build-time profiling support (see
HelloClasslist),
That'd be good if we can improve that.
Post by Claes Redestad
but this will require more time, and I'd like to get this regression fix
into 11 to avoid a few small startup regressions that crept into the
last couple of promoted builds.
Glad that you catch the startup regression.
Post by Claes Redestad
Webrev: http://cr.openjdk.java.net/~redestad/8205926/jdk.00/
+1

Mandy

Loading...